Re: [PATCH] Add support for diffie-hellman-group16-sha512

[Anderson Sasaki <ansasaki@xxxxxxxxxx>]

----- Original Message -----
> From: "Aris Adamantiadis" <aris@xxxxxxxxxxxx>
> To: libssh@xxxxxxxxxx
> Sent: Monday, September 10, 2018 5:26:48 PM
> Subject: Re: [PATCH] Add support for diffie-hellman-group16-sha512
> 
> Hi Anderson,
> 
> Thanks for your contribution. I am not particularly fond of hardcoded DH
> groups such as group14 or group16, especially since we have
> dh-group-exchange now. Is it needed to connect to some device that has
> group16 but doesn't have dh-gex?

The objective is to allow the use of large groups (> 2048 bits) as defined in RFC 8268 [1].
It would be interesting to have this support in libssh.
I am planning to add other hardcoded groups (at least group18), if you agree on this.

Best Regards,
Anderson

[1] https://tools.ietf.org/html/rfc8268