Re: [PATCH 1/1] pki: add support for sk-ecdsa and sk-ed25519

[Sebastian Kinne <skinne@xxxxxxxxxx>]

Hi Andreas,

Thanks for looking at this. Apologies for not using gitlab CI from
the beginning.

I have attached the updated patch, rebased on master, which
has all CI passing:
https://gitlab.com/sebkinne/libssh-mirror/pipelines/102152809

Thanks!
Sebastian


On Wed, Dec 11, 2019 at 12:11 AM Andreas Schneider <asn@xxxxxxxxxxxxxx> wrote:
>
> On Thursday, 5 December 2019 23:35:49 CET Sebastian Kinne wrote:
> > This adds server-side support for the newly introduced OpenSSH
> > keytypes sk-ecdsa-sha2-nistp256@xxxxxxxxxxx and sk-ed25519@xxxxxxxxxxx
> > (including their corresponding certificates), which are backed
> > by U2F/FIDO2 tokens.
>
> Hello Sebastian,
>
> thank you very much for your contribution. I've applied your patch to a branch
> and pushed it to gitlab to get a CI run.
>
> I'm sorry but it is failing with different issues. Please check
>
> https://gitlab.com/cryptomilk/libssh-mirror/pipelines/101985743
>
> and fix the bugs. If you fork from
>
> https://gitlab.com/libssh/libssh-mirror and push a branch to your fork, you
> will get CI for libssh.
>
>
> Thanks.
>
>
>         Andreas
>
> --
> Andreas Schneider                 asn@xxxxxxxxxxxxxx
> GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D

Attachment: 0001-pki-add-support-for-sk-ecdsa-and-sk-ed25519.patch
Description: Binary data