Re: [PATCH 1/1] pki: add support for sk-ecdsa and sk-ed25519

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Wednesday, 11 December 2019 01:42:42 CET Sebastian Kinne wrote:
> Hi Andreas,

Hi Sebastian,
 
> Thanks for looking at this. Apologies for not using gitlab CI from
> the beginning.

no problem :-)
 
> I have attached the updated patch, rebased on master, which
> has all CI passing:
> https://gitlab.com/sebkinne/libssh-mirror/pipelines/102152809

a) Could you please split the patch and put the pki_sha256() function into a 
separate commit? I would also use uint8_t instead of unsigend char in 
pki_sha256().

b) Could you please add tests for this new features? See e.g.

https://gitlab.com/libssh/libssh-mirror/commit/
04b284dae02858b151ab75704eb15facf3781551


Untested code is broken code ;-)


Thanks.


	Andreas


-- 
Andreas Schneider                 asn@xxxxxxxxxxxxxx
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D