Re: [PATCH 1/1] pki: add support for sk-ecdsa and sk-ed25519

[Sebastian Kinne <skinne@xxxxxxxxxx>]

Hi,

> a) Could you please split the patch and put the pki_sha256() function into a
> separate commit? I would also use uint8_t instead of unsigend char in
> pki_sha256().

Done, please see attached.

> b) Could you please add tests for this new features? See e.g.
> https://gitlab.com/libssh/libssh-mirror/commit/
> 04b284dae02858b151ab75704eb15facf3781551

Would you be able to provide some guidance here? I'm not sure how to best
structure the tests in this case. We only have the public key available for
testing.

Would parsing the base64 encoded public key and validating a known
signature against a known piece of data be acceptable?

I implemented similar tests for golang.org/x/crypto/ssh:
https://github.com/golang/crypto/blob/master/ssh/keys_test.go#L578

If so, would it be appropriate to add two new torture_pki_sk_*.c files
and perform the above tests there?

Thanks!
Sebastian

Attachment: 0002-pki-add-support-for-sk-ecdsa-and-sk-ed25519.patch
Description: Binary data

Attachment: 0001-pki-add-sha256-helper-function.patch
Description: Binary data