[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] Use inttypes macros for size_t format string
[Thread Prev] | [Thread Next]
- Subject: Re: [patch] Use inttypes macros for size_t format string
- From: Jakub Jelen <jjelen@xxxxxxxxxx>
- Reply-to: libssh@xxxxxxxxxx
- Date: Wed, 15 Jan 2020 14:35:39 +0100
- To: libssh@xxxxxxxxxx
On Wed, 2020-01-15 at 13:01 +0100, g4-lisz@xxxxxxxxxxxx wrote: > Hi there, here's a patch for fixing a printf format string issue when > compiling with MinGW (and possibly other "architectures"...). > > A big thanks to Zdenek OGAR Skalak for the hint! Looks good to me. Grepping through the rest of the code shows that there will most probably be more issues like this: $ git grep "PRIdS" | wc -l 10 $ git grep "%zu" | wc -l 27 Could you check also the other cases to make sure we can address it in the whole codebase? Andreas, what do you suggest to make sure we do not introduce new issues like this? Regards, -- Jakub Jelen Senior Software Engineer Security Technologies Red Hat, Inc.
Re: [patch] Use inttypes macros for size_t format string | g4-lisz@xxxxxxxxxxxx |
Re: [patch] Use inttypes macros for size_t format string | Andreas Schneider <asn@xxxxxxxxxxxxxx> |
[patch] Use inttypes macros for size_t format string | g4-lisz@xxxxxxxxxxxx |