[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] Use inttypes macros for size_t format string

On Wednesday, 15 January 2020 14:35:39 CET Jakub Jelen wrote:
> On Wed, 2020-01-15 at 13:01 +0100, g4-lisz@xxxxxxxxxxxx wrote:
> > Hi there, here's a patch for fixing a printf format string issue when
> > compiling with MinGW (and possibly other "architectures"...).
> > 
> > A big thanks to Zdenek OGAR Skalak for the hint!
> Looks good to me. Grepping through the rest of the code shows that
> there will most probably be more issues like this:
> $ git grep "PRIdS" | wc -l
> 10
> $ git grep "%zu" | wc -l
> 27
> Could you check also the other cases to make sure we can address it in
> the whole codebase?
> Andreas, what do you suggest to make sure we do not introduce new
> issues like this?

%zu is ANSI C99


That's more than 20 years old now. We had PRIdS because Visual Studio didn't 
have %zu support for a long time. So we should replace PRIdS with %zu ;-)

Till, I'm sorry but you hit a compiler bug, open a bug against MinGW.


Andreas Schneider                 asn@xxxxxxxxxxxxxx
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D

Archive administrator: postmaster@lists.cynapses.org