[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] channels regression issue


Hi Andreas and all,


Am Mi., 1. Apr. 2020 um 15:49 Uhr schrieb Heiko Thiery <heiko.thiery@xxxxxxxxx>:
>
> Hi All,
>
> Am Mi., 1. Apr. 2020 um 08:08 Uhr schrieb Andreas Schneider
> <asn@xxxxxxxxxxxxxx>:
> >
> > On Monday, 30 March 2020 15:53:05 CEST Heiko Thiery wrote:
> > > It was observed that with an updated version of libssh we see a timeout
> > > in the netopeer2-cli when connecting via ssh. This timeout appears after
> > > about 20 seconds of inactivity a new cli command is executed. Since this
> > > issue was not seen with libssh 0.9.2 I started some some debug/bisect and I
> > > figured out that setting the rc variable to the len value before
> > > checking "> 0" solves the issue.
> >
> > Hello Heiko,
> >
> > could you please create a Merge Request for the patches at:
> >
> > https://gitlab.com/libssh/libssh-mirror/
> >
> > This way we get some CI runs.
>
> Ok, I will do a pull-request.

I created a pull-request and the CI runs pass.

>
> >
> > The next question would be if you could write a test for it :-)
>
> I can take a look on that.

Can anyone give me some hints how I can create these tests?

BR,
--
Heiko

Follow-Ups:
Re: [RFC] channels regression issueJakub Jelen <jjelen@xxxxxxxxxx>
References:
Re: [RFC] channels regression issueAndreas Schneider <asn@xxxxxxxxxxxxxx>
Re: [RFC] channels regression issueHeiko Thiery <heiko.thiery@xxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org