Re: [PATCH] packet: Change the last argument of ssh_packet_encrypt to uint32_t
- Subject: Re: [PATCH] packet: Change the last argument of ssh_packet_encrypt to uint32_t
- From: Jakub Jelen <jjelen@xxxxxxxxxx>
- Reply-to: libssh@xxxxxxxxxx
- Date: Wed, 12 May 2021 16:34:45 +0200
- To: libssh@xxxxxxxxxx
On 5/11/21 6:30 AM, Xiang Xiao wrote:
My signoff email was just sent to 'contributing@xxxxxxxxxx
<mailto:contributing@xxxxxxxxxx>'. Please check it.
it looks fine.
I just pushed couple of changes from the gitlab merge requests, but I
had to revert the ones that had wrong signoff/author combination. Can
you resend them again? Either here or on gitlab according to your
preference. These are just the three commits here on the mailing list.
On Mon, May 10, 2021 at 8:58 PM Andreas Schneider <asn@xxxxxxxxxxxxxx
On Sunday, 9 May 2021 16:47:58 CEST Xiang Xiao wrote:
> to match the implemntation in packet_crypt.c
> Signed-off-by: Xiang Xiao <xiaoxiang@xxxxxxxxxx
Hi Xian Xiao,
thank you very much for your contributions. Your author email
the email signing off the commit. So it is not clear if you're
an individual contributor or on behave of a company.
If you're submitting on behave of your company, we need a
Now the problem is that the commits went in before we had a
Origin from you.
This means we need to revert the patches which already went upstream
is clarified. You need to send patches where the author sign-off
I hope you understand that.
Sorry for not replying earlier but I attended a conference last week
didn't check mails.
> Change-Id: Ib76c3585f67dae22ed0f1dfc10dadcd03c762032
> include/libssh/packet.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/include/libssh/packet.h b/include/libssh/packet.h
> index 8fc7ce42..561bba8e 100644
> --- a/include/libssh/packet.h
> +++ b/include/libssh/packet.h
> @@ -80,7 +80,7 @@ int ssh_packet_decrypt(ssh_session session, uint8_t
> *destination, uint8_t *sourc size_t start, size_t encrypted_size);
> unsigned char *ssh_packet_encrypt(ssh_session session,
> void *packet,
> - unsigned int len);
> + uint32_t len);
> int ssh_packet_hmac_verify(ssh_session session, const void
> len, unsigned char *mac, enum ssh_hmac_e type); int
> ssh_packet_set_newkeys(ssh_session session,
Andreas Schneider asn@xxxxxxxxxxxxxx <mailto:asn@xxxxxxxxxxxxxx>
Senior Software Engineer
Crypto Team, Security Engineering
Red Hat, Inc.
Archive administrator: firstname.lastname@example.org