Re: [PATCH] packet: Change the last argument of ssh_packet_encrypt to uint32_t

[Xiang Xiao <xiaoxiang781216@xxxxxxxxx>]

Sure, I will provide the patch through gitlab once you revert the change.

On Wed, May 12, 2021 at 10:35 PM Jakub Jelen <jjelen@xxxxxxxxxx> wrote:

> On 5/11/21 6:30 AM, Xiang Xiao wrote:
> > Andreas,
> > My signoff email was just sent to 'contributing@xxxxxxxxxx
> > <mailto:contributing@xxxxxxxxxx>'. Please check it.
>
> Thank you,
> it looks fine.
>
> I just pushed couple of changes from the gitlab merge requests, but I
> had to revert the ones that had wrong signoff/author combination. Can
> you resend them again? Either here or on gitlab according to your
> preference. These are just the three commits here on the mailing list.
>
> Thanks,
> Jakub
>
> > On Mon, May 10, 2021 at 8:58 PM Andreas Schneider <asn@xxxxxxxxxxxxxx
> > <mailto:asn@xxxxxxxxxxxxxx>> wrote:
> >
> >     On Sunday, 9 May 2021 16:47:58 CEST Xiang Xiao wrote:
> >      > to match the implemntation in packet_crypt.c
> >      >
> >      > Signed-off-by: Xiang Xiao <xiaoxiang@xxxxxxxxxx
> >     <mailto:xiaoxiang@xxxxxxxxxx>>
> >
> >     Hi Xian Xiao,
> >
> >     thank you very much for your contributions. Your author email
> >     differes from
> >     the email signing off the commit. So it is not clear if you're
> >     contributing as
> >     an individual contributor or on behave of a company.
> >
> >     If you're submitting on behave of your company, we need a
> >     Certificate of
> >     Origin.
> >
> >     https://git.libssh.org/projects/libssh.git/tree/CONTRIBUTING.md
> >     <https://git.libssh.org/projects/libssh.git/tree/CONTRIBUTING.md>
> >
> >     Now the problem is that the commits went in before we had a
> >     Certificate of
> >     Origin from you.
> >
> >     This means we need to revert the patches which already went upstream
> >     till this
> >     is clarified. You need to send patches where the author sign-off
> >     matches.
> >
> >     I hope you understand that.
> >
> >     Sorry for not replying earlier but I attended a conference last week
> >     and
> >     didn't check mails.
> >
> >
> >     Thanks
> >
> >
> >              Andreas
> >
> >
> >      > Change-Id: Ib76c3585f67dae22ed0f1dfc10dadcd03c762032
> >      > ---
> >      >  include/libssh/packet.h | 2 +-
> >      >  1 file changed, 1 insertion(+), 1 deletion(-)
> >      >
> >      > diff --git a/include/libssh/packet.h b/include/libssh/packet.h
> >      > index 8fc7ce42..561bba8e 100644
> >      > --- a/include/libssh/packet.h
> >      > +++ b/include/libssh/packet.h
> >      > @@ -80,7 +80,7 @@ int ssh_packet_decrypt(ssh_session session,
> uint8_t
> >      > *destination, uint8_t *sourc size_t start, size_t encrypted_size);
> >      >  unsigned char *ssh_packet_encrypt(ssh_session session,
> >      >                                    void *packet,
> >      > -                                  unsigned int len);
> >      > +                                  uint32_t len);
> >      >  int ssh_packet_hmac_verify(ssh_session session, const void
> >     *data, size_t
> >      > len, unsigned char *mac, enum ssh_hmac_e type); int
> >      > ssh_packet_set_newkeys(ssh_session session,
> >
> >
> >     --
> >     Andreas Schneider asn@xxxxxxxxxxxxxx <mailto:asn@xxxxxxxxxxxxxx>
> >     GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
> >
> >
>
>
> --
> Jakub Jelen
> Senior Software Engineer
> Crypto Team, Security Engineering
> Red Hat, Inc.
>
>
>