Re: Sending arbitrary messages between key exchange and user authentication

[Aris Adamantiadis <aris@xxxxxxxxxxxx>]

Hi Martin,

Thanks for your patch ! Here is my feedback:
libssh.h: We try to order functions in alphabetical order. Could you
move your functions so they match it ?

session.c: You should not include ssh1.h for a ssh2-specific packet. I
believe the problem is that you're sending SSH_MSG_IGNORE, when SSH2
specific packet numbers have been renamed to SSH2_MSG_*.

comments: It is good that you provide doxygen doc. Please copy and paste
the description of "session" parameters and return values from an other
function, so it matches with other doc. We'll probably work one day to
uniformize it.

/* Empty language tag */
str = ...

this assignation overwrites a valid pointer and causes a memory leak.

Don't worry about the number of changes I request, it's normal for a
first commit.

The best way to send us a patch is documented here :
https://red.libssh.org/projects/libssh/wiki/Patches
That way, you'll get credit for your commit inside our git tree.

Thanks a lot for your efforts.
Kr,

Aris



Le 17/10/11 13:46, Martin Drasar a écrit :
> Hi,
> 
> I have just finsihed the patch for sending ignore and debug messages. If
> you like it - commit it, otherwise tell me what is wrong and I will fix
> it ;-)
> 
> Martin