Re: Issues with Connector on net sockets

[g4-lisz@xxxxxxxxxxxx]

On 28.01.19 19:38, Andreas Schneider wrote:
> On Monday, January 28, 2019 7:08:52 PM CET g4-lisz@xxxxxxxxxxxx wrote:
>> It seems that I'm the only one using connectors. In the few samples I
>> found it's only used to read/write from/to console. So the stdin and
>> -out file handles don't need explicit close / EOF, hence the issue from
>> above is not relevant.
>>
>> Now I also found what I think is a bug in the connector API. Anyone
>> interested in this?
>>
>> Ok I guess I open a new "thread" on this - I also have a simple patch
>> for it.
> Hi Till,
>
> the connector API has been implemented by Aris, I haven't looked deeply into 
> it. It works both on server and client however I don't think we have detailed 
> tests for it and this is probably the issue. We need test and test several 
> aspects of it in order to get it right. So if you have found a bug, it would 
> be great if you could add a test to reproduce it. Then fix it.
>
> Once you have one test, most of the time it is easy to add another as you 
> already have the code and you can quickly find other issues and test the 
> corner cases.
>
> Also it makes sure we don't break the functionality in future.
>
> It would be great if you could look into that and provide patches.

Hi Andreas,

ok I will do this. The patch is ready already, but not the test ;-)

Maybe Aris could answer the question if this API was intended to work
with adding and removing connectors while in the main / polling loop...

Till